[pve-devel] [PATCH v3 storage 1/2] volume_resize: use KiB instead of bytes

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Feb 19 07:51:03 CET 2020


On 2/18/20 4:09 PM, Dominik Csapak wrote:
> series LGTM (one comment on the relevant patch), works as intended
> 

can I get some tags I can work with or should I introduce the
Looks-good-to-me-by: ...

tag :D Or do you want to wait on a followup?

> a few high level comments (only tangentially  related,
> afaics the behaviour for my comments are the same):
> 
> resizing by low values, e.g. 1K does not always work
> for directory storages and lxc, resize2fs did not want to
> resize
> 
> we pad to 1M for LVM/ZFS, but not for RBD but this
> also only takes M/G/T on its commandline,
> maybe we should do the same there?
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 





More information about the pve-devel mailing list