[pve-devel] [PATCH manager] fix #2598: prepare/activate volumes after stopping container for backup

Oguz Bektas o.bektas at proxmox.com
Tue Feb 18 13:35:21 CET 2020


when doing a 'stop' backup with an LVM backend, volumes are deactivated
by the stop operation. they're not activated before the backup, which
causes it to fail because of mount/unmount problems.

call prepare() after stop_vm() instead to activate volumes beforehand.

[0]: https://forum.proxmox.com/threads/problem-backups-proxmox-6-1.65317/

Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
---
 PVE/VZDump.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index 87d4b699..514f432b 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -757,7 +757,6 @@ sub exec_backup_task {
 
 	if ($mode eq 'stop') {
 
-	    $plugin->prepare ($task, $vmid, $mode);
 
 	    $self->run_hook_script ('backup-start', $task, $logfd);
 
@@ -766,6 +765,7 @@ sub exec_backup_task {
 		$task->{vmstoptime} = time();
 		$self->run_hook_script ('pre-stop', $task, $logfd);
 		$plugin->stop_vm ($task, $vmid);
+		$plugin->prepare ($task, $vmid, $mode);
 		$cleanup->{restart} = 1;
 	    }
 
-- 
2.20.1



More information about the pve-devel mailing list