[pve-devel] [PATCH ifupdown2 2/2] add openvswitch addon

[Alexandre DERUMIER]

>>Oh, and yes, if this breaks the old way of specifying ovs interfaces some 
>>compatibillity would be great, e.g., with your mentioned postinst script 

What do you think about this simple postinst script ?

"
use PVE::INotify;
my $config = PVE::INotify::read_file('interfaces', 1);
my $configdata = $config->{data};

if(defined($config->{changes})) {
    PVE::INotify::write_file('interfaces', $configdata);
    print "network config changes has been detected and generated in /etc/network/interfaces.new\n";
    print "Please reload network configuration in gui\n";
}
"

Like this, user can still review the changes, reload it manually, on get applied on next reboot





----- Mail original -----
De: "Thomas Lamprecht" <t.lamprecht at proxmox.com>
À: "pve-devel" <pve-devel at pve.proxmox.com>, "aderumier" <aderumier at odiso.com>
Envoyé: Lundi 17 Février 2020 15:46:39
Objet: Re: [pve-devel] [PATCH ifupdown2 2/2] add openvswitch addon

On 2/17/20 1:51 PM, Alexandre Derumier wrote: 
> This reimplement the ifupdown1 script with same options, 
> 
> with reloading included ! 
> --- 
> debian/patches/series | 1 + 
> 1 file changed, 1 insertion(+) 
> 
> diff --git a/debian/patches/series b/debian/patches/series 
> index 3f39fc8..b8c348c 100644 
> --- a/debian/patches/series 
> +++ b/debian/patches/series 
> @@ -6,3 +6,4 @@ pve/0004-don-t-remove-bridge-is-tap-veth-are-still-plugged.patch 
> pve/0005-ifreload-down-up-vxlan-interfaces-when-ifreload_down.patch 
> pve/0006-config-tuning.patch 
> pve/0007-networking.service-fix-dependencies-and-ordering.patch 
> +pve/0008-add-openvswitch-addon.patch 
> 

could it be that the actual "pve/0008-add-openvswitch-addon.patch" patch 
wasn't added to the git index? :) 

Oh, and yes, if this breaks the old way of specifying ovs interfaces some 
compatibillity would be great, e.g., with your mentioned postinst script 
(as network isn't automatically reloaded on installation/update, or is it?)