[pve-devel] [RFC manager] Display subdirs when listing storage content

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Feb 13 09:12:24 CET 2020


On 12/2/19 12:45 PM, Dominic Jäger wrote:
> iso and vztmpl files can be in subdirectories of a storage's directory.
> In this case we must make clear where they are exactly.
>
> Signed-off-by: Dominic Jäger <d.jaeger at proxmox.com>
> ---
> Useless without the patch for pve-storage.
>
>  www/manager6/Utils.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
> index ad75c871..ccfd72fd 100644
> --- a/www/manager6/Utils.js
> +++ b/www/manager6/Utils.js
> @@ -661,7 +661,7 @@ Ext.define('PVE.Utils', { utilities: {
>  		Ext.String.leftPad(data.channel,2, '0') +
>  		" ID " + data.id + " LUN " + data.lun;
>  	}
> -	return data.volid.replace(/^.*:(.*\/)?/,'');
> +	return data.volid.replace(/^.*:[^\/]*\//,'');

what if a volid does not contain any slash? Previously we could cope with none or
the first one, not with any amount but not none, or? Maybe something like (untested):

return data.volid.replace(/^.*:([^\/]*\/)?/,'');

>      },
>  
>      render_serverity: function (value) {
>





More information about the pve-devel mailing list