[pve-devel] applied: [PATCH manager] gui: form/ControllerSelector: fix autoselection

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Feb 12 12:36:47 CET 2020


On 2/12/20 10:51 AM, Dominik Csapak wrote:
> changing from Ext.Array.each to a for loop and changing the return
> to a 'break', resulted in exiting the wrong loop (previously the outer,
> now the inner) resulting in wrongly looping through all controllers
> instead of only until we found a match
> 
> using a label and labeled break, we can break the outer loop
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  www/manager6/form/ControllerSelector.js | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

argh, thanks for finding and fixing this! applied




More information about the pve-devel mailing list