[pve-devel] applied: [PATCH manager v2 1/2] gui: TFAEdit: use viemodel binding for hiding/showing qr code

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Feb 11 19:02:03 CET 2020


On 2/11/20 10:01 AM, Dominik Csapak wrote:
> the verification textfield, and the selected tab.
> 
> also remove the code that used the value by the userview panel, since
> this is the only way to have a consistent behaviour on the userview
> setting and the usermenu tfa setting
> 
> this fixes the issue that on the 'user menu' we accidentally showed
> the qr code and verification field, even if the user already had a
> totp code
> 
> now it shows 'Unchanged' like when opened via dc/UserView
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> changes from v1:
> * remove the code that handles the tfa type of the user.cfg and
>   always rely on the tfa api call, to get consistent behaviour
>   everywhere
> * control the active tab via bind (this is not a two-way bind)
> 
>  www/manager6/dc/TFAEdit.js | 51 +++++++++++++++++++++++++-------------
>  1 file changed, 34 insertions(+), 17 deletions(-)
> 

now all works well, much thanks! applied



More information about the pve-devel mailing list