[pve-devel] [RFC qemu-server 14/16] Allow specifying targetstorage for offline migration

[Fabian Grünbichler]

On January 29, 2020 2:30 pm, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
>  PVE/API2/Qemu.pm | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index 89e2477..f21fb69 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -3379,9 +3379,6 @@ __PACKAGE__->register_method({
>  	    $param->{online} = 0;
>  	}
>  
> -	raise_param_exc({ targetstorage => "Live storage migration can only be done online." })
> -	    if !$param->{online} && $param->{targetstorage};
> -

maybe it makes sense to add a pointer to maybe try live-migration in 
case offline fails? e.g., zvol -> raw is not supported by 
storage_migrate, but is by NBD (as long as no snapshots exist).

>  	my $storecfg = PVE::Storage::config();
>  
>  	if( $param->{targetstorage}) {
> -- 
> 2.20.1