[pve-devel] [PATCH manager] ui: improve description of guest-fstrim checkbox

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Dec 16 08:20:32 CET 2020


On 15.12.20 16:22, Aaron Lauterer wrote:
> The phrasing left some room to speculation when this would actually be
> run, e.g. after cloning a full VM?

Adding/Expanding a QGA pve-docs section with that info in detail and adding
a onlineHelp button here would be also great, allows to explain it in full
detail without the need for shorter abbreviated sentences.

> 
> Currently the only instances where it is used is after moving a disk or
> migrating a VM.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
> ---
>  www/manager6/form/AgentFeatureSelector.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js
> index 122c8713..6c21306f 100644
> --- a/www/manager6/form/AgentFeatureSelector.js
> +++ b/www/manager6/form/AgentFeatureSelector.js
> @@ -14,7 +14,7 @@ Ext.define('PVE.form.AgentFeatureSelector', {
>  	},
>  	{
>  	    xtype: 'proxmoxcheckbox',
> -	    boxLabel: gettext('Run guest-trim after clone disk'),
> +	    boxLabel: gettext('Run guest-trim after a disk move or VM migration'),
>  	    name: 'fstrim_cloned_disks',
>  	    bind: {
>  		disabled: '{!enabled.checked}',
> 






More information about the pve-devel mailing list