[pve-devel] applied: [PATCH storage] prune mark: correctly keep track of already included backups

[Thomas Lamprecht]

On 14.12.20 16:03, Fabian Ebner wrote:
> This needs to happen in a separate loop, because some time intervals are not
> subsets of others, i.e. weeks and months. Previously, with a daily backup
> schedule, having:
> * a backup on Sun, 06 Dec 2020 kept by keep-daily
> * a backup on Sun, 29 Nov 2020 kept by keep-weekly
> would lead to the backup on Mon, 30 Nov 2020 to be selected for keep-monthly,
> because the iteration did not yet reach the backup on Sun, 29 Nov 2020 that
> would mark November as being covered.
> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
> 
> The PBS implementation is not affected by this as it uses two loops.
> I don't see how this would cause bug #3199 though...
> 
>  PVE/Storage.pm             | 11 +++++----
>  test/prune_backups_test.pm | 49 ++++++++++++++++++++++++++++++++++++++
>  2 files changed, 55 insertions(+), 5 deletions(-)
> 
>

applied, thanks!