[pve-devel] [PATCH widget-toolkit v2 1/3] EditWindow: Change url to 'importdisk' for import

Dominic Jäger d.jaeger at proxmox.com
Mon Aug 24 10:42:02 CEST 2020


On Thu, Aug 20, 2020 at 05:36:52PM +0200, Thomas Lamprecht wrote:
> On 30.07.20 12:18, Dominic Jäger wrote:
> > --- a/src/window/Edit.js
> > +++ b/src/window/Edit.js
> > @@ -134,6 +134,10 @@ Ext.define('Proxmox.window.Edit', {
> > +	if (me.isImport) {
> > +	    url = url.replace('config', 'importdisk');
> > +	}
> I'd rather avoid doing this here, i.e., the common shared code should not
> do such transforming things specific for a single use case downstream..
> That adds coupling, which should be avoided if possible.
> 
> Why can the import window instance not handle this?
> 
> sorry to catch this only now..
> 
This was the first way that I found that resulted in a working prototype.  And
I wasn't sure if this is actually the right direction for this patch, so I left
it like that for the moment.

I'll think of a better way.




More information about the pve-devel mailing list