[pve-devel] applied: [PATCH qemu] PVE: add zero block handling to PBS dump callback

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Aug 19 15:42:08 CEST 2020


On 13.08.20 13:50, Stefan Reiter wrote:
> Both the PBS and VMA dump callbacks assume that a NULL pointer can be
> passed as *pbuf, but that never happens, as backup-dump.c calls this
> function with contents of an iovec.
> 
> So first, remove that assumption and add an 'assert' to verify.
> 
> Secondly, while the vma-writer already does the buffer_is_zero check
> internally, for PBS we relied on that non-existant behaviour for zero
> chunks, so do the buffer_is_zero check manually and pass NULL to the
> rust lib in case it is true.
> 
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> ---
> 
> This increases backup speed to PBS for VMs with free space quite dramatically.
> 
>  pve-backup.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
>

applied, thanks!




More information about the pve-devel mailing list