[pve-devel] applied: [PATCH common] safe_read_from: bump default size limit to 512k

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Aug 19 07:39:08 CEST 2020


On 14.08.20 09:48, Fabian Grünbichler wrote:
> this is (via file_get_contents and file_copy) used for reading from
> pmxcfs, which has a file size limit of 512k. since quite a number of
> call sites would need to explicitly override this (and then get updated
> if we bump the limit on the pmxcfs side again in the future), making our
> default file reader compatible by default seems the better solution.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
> 
> Notes:
>     actual real-world example of hitting this issue:
>     
>     https://forum.proxmox.com/threads/backup-failed-file-etc-pve-firewall-100-fw-too-long-aborting.74348/
> 
>  src/PVE/Tools.pm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>

applied, thanks!





More information about the pve-devel mailing list