[pve-devel] [RFC qemu] allow backup of read-only block drives

Fabian Grünbichler f.gruenbichler at proxmox.com
Thu Aug 6 13:13:49 CEST 2020


this is needed for template backups with PBS until we have the backup
equivalent of 'pbs-restore'.

Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
---
did some quick tests and didn't run into any issues - @Dietmar/@Stefan
is that check needed for some non-obvious reason?

 .../0029-PVE-Backup-proxmox-backup-patches-for-qemu.patch   | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/debian/patches/pve/0029-PVE-Backup-proxmox-backup-patches-for-qemu.patch b/debian/patches/pve/0029-PVE-Backup-proxmox-backup-patches-for-qemu.patch
index 56161cc..7b4834a 100644
--- a/debian/patches/pve/0029-PVE-Backup-proxmox-backup-patches-for-qemu.patch
+++ b/debian/patches/pve/0029-PVE-Backup-proxmox-backup-patches-for-qemu.patch
@@ -527,7 +527,7 @@ new file mode 100644
 index 0000000000..9ae89fb679
 --- /dev/null
 +++ b/pve-backup.c
-@@ -0,0 +1,959 @@
+@@ -0,0 +1,955 @@
 +#include "proxmox-backup-client.h"
 +#include "vma.h"
 +
@@ -1050,10 +1050,6 @@ index 0000000000..9ae89fb679
 +            blk = blk_by_name(*d);
 +            if (blk) {
 +                bs = blk_bs(blk);
-+                if (bdrv_is_read_only(bs)) {
-+                    error_setg(task->errp, "Node '%s' is read only", *d);
-+                    goto err;
-+                }
 +                if (!bdrv_is_inserted(bs)) {
 +                    error_setg(task->errp, QERR_DEVICE_HAS_NO_MEDIUM, *d);
 +                    goto err;
-- 
2.20.1





More information about the pve-devel mailing list