[pve-devel] applied: [PATCH qemu-server 1/2] migrate: only stop NBD if we got a NBD url from the target

[Mira Limbeck]

On 4/30/20 10:13 AM, Thomas Lamprecht wrote:
> On 4/30/20 10:04 AM, Mira Limbeck wrote:
>> On 4/30/20 8:41 AM, Thomas Lamprecht wrote:
>>> On 4/30/20 8:35 AM, Fabian Grünbichler wrote:
>>>> On April 29, 2020 4:24 pm, Thomas Lamprecht wrote:
>>>>> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
>>>>> ---
>>>>>
>>>>> This was rather quickly assembled to fix an obvious issue, some in depth look
>>>>> at this would be nice, @Fabi or @Fabian :)
>>>> LGTM!
>>>>
>>> It really should be OK, but I'm still a bit wondering why "$self->{storage_migration}"
>>> was true in my case, a VM with only a single disk on ceph..
>>> Not that the reason for this can have other fallout.
>> I'm wondering that too. I tried reproducing it with qemu-server 6.1-14 and could not (using an external ceph cluster as storage).
>>
>> Did you test it with qemu-server 6.1-15 or an even newer version? Was the disk in $local_volumes for some reason?
>>
> Fabian investigated and got the reason, see:
> https://pve.proxmox.com/pipermail/pve-devel/2020-April/043272.html
>
Yes, sorry for the noise, haven't catched up yet completely with 
everything. Reading up on it atm.