[pve-devel] applied: [PATCH qemu-server 2/2] qm nbdstop: cope graceful with errors

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Apr 29 16:24:49 CEST 2020


as the nbd server could have been stopped by something else.
Further, it makes no sense to die and mark the migration thus as
failed, just because of a NBD server stop issue.

At this point the migration hand off to the target was done already,
so normally we're good, if it fails we have other (followup) problems
anyway.

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---
 PVE/CLI/qm.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index f99d401..282fa86 100755
--- a/PVE/CLI/qm.pm
+++ b/PVE/CLI/qm.pm
@@ -274,7 +274,8 @@ __PACKAGE__->register_method ({
 
 	my $vmid = $param->{vmid};
 
-	PVE::QemuServer::nbd_stop($vmid);
+	eval { PVE::QemuServer::nbd_stop($vmid) };
+	warn $@ if $@;
 
 	return undef;
     }});
-- 
2.20.1





More information about the pve-devel mailing list