[pve-devel] [PATCH manager v2] ui: dc/Auth: add sync button

[Thomas Lamprecht]

On 4/29/20 1:54 PM, Dominik Csapak wrote:
> copy/pasted the other mail to only write on answer:
> 
> On 4/29/20 1:52 PM, Thomas Lamprecht wrote:
>> On 4/27/20 4:40 PM, Dominik Csapak wrote:
>>> opens a window with the parameters for the sync and two buttons:
>>> 'preview' and 'sync'
>>>
>>> both open the taskviewer, but the 'preview' one sets the 'no-write'
>>> parameter so that it does not get written out to the user.cfg
>>>
>>
>> Oh, and maybe it's nicer if the "Preview" kept the sync window open?
>> So that if the preview looks good a user can just do the real sync.
>>
> 
> yeah that makes sense
> 
> On 4/29/20 1:49 PM, Thomas Lamprecht wrote:
>> On 4/27/20 4:40 PM, Dominik Csapak wrote:
>>> opens a window with the parameters for the sync and two buttons:
>>> 'preview' and 'sync'
>>>
>>> both open the taskviewer, but the 'preview' one sets the 'no-write'
>>> parameter so that it does not get written out to the user.cfg
>>>
>>> loads the realm config and prefills the selection with values from
>>> the config
>>>
>>> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
>>> ---
>>> changes from v1:
>>> * load realm config and set appropriate values
>>> * mark loaded values as such ({0} (from Config))
>>> * wrapped the ipanel in a form to easier get the validity
>>> * changed to a controller to better to have better access to
>>>    the components and their handlers
>>> * remove the 'default' options from fields that do not have one,
>>>    set the initial value to '' and allowBlank to false so that
>>>    they are not valid by default (either set from config or manually chosen)
>>>
>>> i am not completely happy with how manual this whole thing is, but
>>> i (for now) could not come up with a better method without completely
>>> changing the ux (e.g showing the defaults separately; which i do not want)
>>>
>>> there are a few possibilities to make this easier when we want
>>> some of those features elsewhere, but for now it does not make sense
>>> to refactor it (e.g. the changing of text of a kvcombobox, or
>>> the manual management of buttons in an edit window)
>>>
>>
>> Hmm, you missed implementing the tooltip I suggested but that's not to relevant..
>> Using this I got the feeling that for the user it is totally irrelevant from
>> where the values come.
> 
> sorry, it seems i really missed this ...
> 
>>
>> So I'd just show them what the value is, no "from Default", no "from Config",
>> and for the case where no default-sync-config values are set at all show a small
>> additional hint alá "You can set the default sync options when editing the realm"
>> or so. Not hard feelings for that hint, but I really thinks it's better to simplify
>> selections here and just show the plain values which will be used.
> 
> so you're ok with showing the empty fields, and when at least one is empty, show the hint?


Rather:

If neither the schema has and default nor the sync-default-options for that field.
is set show it as empty and required

I'd only show the hint if no default sync option is set, as else I assume that the
user already knows about them, but no hard feelings here.

> 
> i'd rather say it like:
> 
> "Default sync options can be set by editing the realm." sounds good?
> 

Sounds ok.