[pve-devel] [PATCH firewall/cluster 0/9] add locking to firewall config changes

Fabian Grünbichler f.gruenbichler at proxmox.com
Wed Apr 29 10:52:47 CEST 2020


the second cluster patch is optional, but improves usability of
non-worker API calls that do

cfs_lock_foo(..., sub {

  raise_foo

});

the last three firewall patches are unrelated bug fixes that I found
while testing.

pve-cluster:

Fabian Grünbichler (2):
  cfs_lock: add firewall lock helper
  cfs_lock: re-raise exceptions

 data/PVE/Cluster.pm | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

pve-firewall:

Fabian Grünbichler (7):
  configs: add locking helpers
  api: add locking helpers
  api: lock configs
  clone_vmfw_conf: lock new config
  api/ipsets: parse_cidr before checking for duplicates
  configs: warn about duplicate ipset entries
  rules: verify referenced security group exists

 src/PVE/API2/Firewall/Aliases.pm | 104 ++++++++++------
 src/PVE/API2/Firewall/Cluster.pm |  36 +++---
 src/PVE/API2/Firewall/Groups.pm  |  52 ++++----
 src/PVE/API2/Firewall/Host.pm    |  42 ++++---
 src/PVE/API2/Firewall/IPSet.pm   | 204 +++++++++++++++++++++----------
 src/PVE/API2/Firewall/Rules.pm   | 130 ++++++++++++++------
 src/PVE/API2/Firewall/VM.pm      |  43 +++----
 src/PVE/Firewall.pm              |  65 ++++++++--
 8 files changed, 449 insertions(+), 227 deletions(-)

-- 
2.20.1





More information about the pve-devel mailing list