[pve-devel] [PATCH storage v5 06/12] test: path_to_volume_id
Alwin Antreich
a.antreich at proxmox.com
Tue Apr 28 15:58:19 CEST 2020
Test to reduce the potential for accidental breakage on regex changes.
Signed-off-by: Alwin Antreich <a.antreich at proxmox.com>
---
test/path_to_volume_id_test.pm | 242 +++++++++++++++++++++++++++++++++
test/run_plugin_tests.pl | 2 +-
2 files changed, 243 insertions(+), 1 deletion(-)
create mode 100644 test/path_to_volume_id_test.pm
diff --git a/test/path_to_volume_id_test.pm b/test/path_to_volume_id_test.pm
new file mode 100644
index 0000000..744c3ee
--- /dev/null
+++ b/test/path_to_volume_id_test.pm
@@ -0,0 +1,242 @@
+package PVE::Storage::TestPathToVolumeId;
+
+use strict;
+use warnings;
+
+use lib qw(..);
+
+use PVE::Storage;
+
+use Test::More;
+
+use Cwd;
+use File::Basename;
+use File::Path qw(make_path remove_tree);
+use File::Temp;
+
+my $storage_dir = File::Temp->newdir();
+my $scfg = {
+ 'digest' => 'd29306346b8b25b90a4a96165f1e8f52d1af1eda',
+ 'ids' => {
+ 'local' => {
+ 'shared' => 0,
+ 'path' => "$storage_dir",
+ 'type' => 'dir',
+ 'maxfiles' => 0,
+ 'content' => {
+ 'snippets' => 1,
+ 'rootdir' => 1,
+ 'images' => 1,
+ 'iso' => 1,
+ 'backup' => 1,
+ 'vztmpl' => 1,
+ },
+ },
+ },
+ 'order' => {
+ 'local' => 1,
+ },
+};
+
+# the tests array consists of hashes with the following keys:
+# description => to identify the test case
+# volname => to create the test file
+# expected => the result that path_to_volume_id should return
+my @tests = (
+ {
+ description => 'Image, qcow2',
+ volname => "$storage_dir/images/16110/vm-16110-disk-0.qcow2",
+ expected => [
+ 'images',
+ 'local:16110/vm-16110-disk-0.qcow2',
+ ],
+ },
+ {
+ description => 'Image, raw',
+ volname => "$storage_dir/images/16112/vm-16112-disk-0.raw",
+ expected => [
+ 'images',
+ 'local:16112/vm-16112-disk-0.raw',
+ ],
+ },
+ {
+ description => 'Image template, qcow2',
+ volname => "$storage_dir/images/9004/base-9004-disk-0.qcow2",
+ expected => [
+ 'images',
+ 'local:9004/base-9004-disk-0.qcow2',
+ ],
+ },
+
+ {
+ description => 'Backup, vma.gz',
+ volname => "$storage_dir/dump/vzdump-qemu-16110-2020_03_30-21_11_40.vma.gz",
+ expected => [
+ 'iso',
+ 'local:backup/vzdump-qemu-16110-2020_03_30-21_11_40.vma.gz',
+ ],
+ },
+ {
+ description => 'Backup, vma.lzo',
+ volname => "$storage_dir/dump/vzdump-qemu-16110-2020_03_30-21_12_45.vma.lzo",
+ expected => [
+ 'iso',
+ 'local:backup/vzdump-qemu-16110-2020_03_30-21_12_45.vma.lzo',
+ ],
+ },
+ {
+ description => 'Backup, vma',
+ volname => "$storage_dir/dump/vzdump-qemu-16110-2020_03_30-21_13_55.vma",
+ expected => [
+ 'iso',
+ 'local:backup/vzdump-qemu-16110-2020_03_30-21_13_55.vma',
+ ],
+ },
+ {
+ description => 'Backup, tar.lzo',
+ volname => "$storage_dir/dump/vzdump-lxc-16112-2020_03_30-21_39_30.tar.lzo",
+ expected => [
+ 'iso',
+ 'local:backup/vzdump-lxc-16112-2020_03_30-21_39_30.tar.lzo',
+ ],
+ },
+
+ {
+ description => 'ISO file',
+ volname => "$storage_dir/template/iso/yet-again-a-installation-disk.iso",
+ expected => [
+ 'iso',
+ 'local:iso/yet-again-a-installation-disk.iso',
+ ],
+ },
+ {
+ description => 'CT template, tar.gz',
+ volname => "$storage_dir/template/cache/debian-10.0-standard_10.0-1_amd64.tar.gz",
+ expected => [
+ 'vztmpl',
+ 'local:vztmpl/debian-10.0-standard_10.0-1_amd64.tar.gz',
+ ],
+ },
+
+ {
+ description => 'Rootdir',
+ volname => "$storage_dir/private/1234/", # fileparse needs / at the end
+ expected => [
+ 'rootdir',
+ 'local:rootdir/1234',
+ ],
+ },
+ {
+ description => 'Rootdir, folder subvol',
+ volname => "$storage_dir/images/1234/subvol-1234-disk-0.subvol/", # fileparse needs / at the end
+ expected => [
+ 'images',
+ 'local:1234/subvol-1234-disk-0.subvol'
+ ],
+ },
+
+ # no matches
+ {
+ description => 'Snippets, yaml',
+ volname => "$storage_dir/snippets/userconfig.yaml",
+ expected => [''],
+ },
+ {
+ description => 'Snippets, hookscript',
+ volname => "$storage_dir/snippets/hookscript.pl",
+ expected => [''],
+ },
+ {
+ description => 'CT template, tar.xz',
+ volname => "$storage_dir/template/cache/debian-10.0-standard_10.0-1_amd64.tar.xz",
+ expected => [''],
+ },
+
+ # no matches, path or files with failures
+ {
+ description => 'Base template, string as vmid in folder name',
+ volname => "$storage_dir/images/ssss/base-4321-disk-0.raw",
+ expected => [''],
+ },
+ {
+ description => 'ISO file, wrong ending',
+ volname => "$storage_dir/template/iso/yet-again-a-installation-disk.dvd",
+ expected => [''],
+ },
+ {
+ description => 'CT template, wrong ending, zip.gz',
+ volname => "$storage_dir/template/cache/debian-10.0-standard_10.0-1_amd64.zip.gz",
+ expected => [''],
+ },
+ {
+ description => 'CT template, wrong ending, tar bz2',
+ volname => "$storage_dir/template/cache/debian-10.0-standard_10.0-1_amd64.tar.bz2",
+ expected => [''],
+ },
+ {
+ description => 'Rootdir as subvol, wrong path',
+ volname => "$storage_dir/private/subvol-19254-disk-0/",
+ expected => [''],
+ },
+ {
+ description => 'Backup, wrong ending, openvz, tar.bz2',
+ volname => "$storage_dir/dump/vzdump-openvz-16112-2020_03_30-21_39_30.tar.bz2",
+ expected => [''],
+ },
+ {
+ description => 'Backup, wrong format, openvz, zip.gz',
+ volname => "$storage_dir/dump/vzdump-openvz-16112-2020_03_30-21_39_30.zip.gz",
+ expected => [''],
+ },
+ {
+ description => 'Backup, wrong format, openvz, tgz.lzo',
+ volname => "$storage_dir/dump/vzdump-openvz-16112-2020_03_30-21_39_30.tgz.lzo",
+ expected => [''],
+ },
+ {
+ description => 'Backup, wrong ending, qemu, vma.xz',
+ volname => "$storage_dir/dump/vzdump-qemu-16110-2020_03_30-21_12_40.vma.xz",
+ expected => [''],
+ },
+ {
+ description => 'Backup, wrong format, qemu, vms.gz',
+ volname => "$storage_dir/dump/vzdump-qemu-16110-2020_03_30-21_12_40.vms.gz",
+ expected => [''],
+ },
+ {
+ description => 'Image, string as vmid in folder name',
+ volname => "$storage_dir/images/ssss/vm-1234-disk-0.qcow2",
+ expected => [''],
+ },
+);
+
+plan tests => scalar @tests;
+
+foreach my $tt (@tests) {
+ my $file = $tt->{volname};
+ my $expected = $tt->{expected};
+ my $description = $tt->{description};
+
+ # prepare environment
+ my ($name, $dir, $suffix) = fileparse($file);
+ make_path($dir, { verbose => 1, mode => 0755 });
+
+ if ($name) {
+ open(my $fh, ">>", "$file") || die "Error open file: $!";
+ close($fh);
+ }
+
+ # run tests
+ my $got;
+ eval { $got = [ PVE::Storage::path_to_volume_id($scfg, $file) ] };
+ $got = $@ if $@;
+
+ is_deeply($got, $expected, $description) || diag(explain($got));
+}
+
+#cleanup
+# File::Temp unlinks tempdir on exit
+
+done_testing();
+
+1;
diff --git a/test/run_plugin_tests.pl b/test/run_plugin_tests.pl
index be8657a..770b407 100755
--- a/test/run_plugin_tests.pl
+++ b/test/run_plugin_tests.pl
@@ -10,7 +10,7 @@ my $res = $harness->runtests(
"archive_info_test.pm",
"parse_volname_test.pm",
"list_volumes_test.pm",
+ "path_to_volume_id_test.pm",
);
exit -1 if !$res || $res->{failed} || $res->{parse_errors};
-
--
2.20.1
More information about the pve-devel
mailing list