[pve-devel] applied: [PATCH manager 5/6] ui: dc/AuthEdit: add sync tab for ldap/ad realms

[Thomas Lamprecht]

On 4/9/20 4:10 PM, Dominik Csapak wrote:
> this modifies AuthEditBase so that if there is a sync inputpanel specified,
> we display it in a second tab (we need to modify the bodyPadding here,
> else the whole window has too much padding)
> 
> we use the same panel for both ldap/ad, since the most options behave
> the same (except for user_attribute, but the default for AD is
> sAMAccount which i think is good enough for now, users can still
> override it in the cli)
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> i have an idea to refactor the whole propertystring parsing/printing
> but it needs more work, since i would have to move some code
> to the widget-toolkit (the Parser class would have to be moved there)
> 
> but this has to wait for now (i really want to do this since
> we have the same pattern quite some times, e.g. for the whole
> net/disk/mp panels in lxc/qemu)
> 
>  www/manager6/Utils.js           |   2 +
>  www/manager6/dc/AuthEditBase.js |  37 ++++++-
>  www/manager6/dc/AuthEditLDAP.js | 185 ++++++++++++++++++++++++++++++++
>  3 files changed, 221 insertions(+), 3 deletions(-)
> 

applied, thanks - albeit I went more for functionality testing and only
a rather quick check for the code itself, just FYI.