[pve-devel] applied: [PATCH manager 2/2] ui: auth realm: do not delete tfa if empty on create

Thomas Lamprecht t.lamprecht at proxmox.com
Sun Apr 26 13:36:19 CEST 2020


that breaks the schema as the POST endpoint obviously doesn't knows
about a delete property.

fixes commit abc12f38995a2e078699cf85e9d1de0a273dc5f2

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---
 www/manager6/dc/AuthEditBase.js  | 1 +
 www/manager6/form/TFASelector.js | 7 ++++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/www/manager6/dc/AuthEditBase.js b/www/manager6/dc/AuthEditBase.js
index 06ebc0bb..2a6862d9 100644
--- a/www/manager6/dc/AuthEditBase.js
+++ b/www/manager6/dc/AuthEditBase.js
@@ -48,6 +48,7 @@ Ext.define('PVE.panel.AuthBase', {
 	// last field of column2is tfa
 	me.column2.push({
 	    xtype: 'pveTFASelector',
+	    deleteEmpty: !me.isCreate,
 	});
 
 	me.columnB.push({
diff --git a/www/manager6/form/TFASelector.js b/www/manager6/form/TFASelector.js
index f27892eb..daf3d555 100644
--- a/www/manager6/form/TFASelector.js
+++ b/www/manager6/form/TFASelector.js
@@ -1,6 +1,9 @@
 Ext.define('PVE.form.TFASelector', {
     extend: 'Ext.container.Container',
     xtype: 'pveTFASelector',
+    mixins: ['Proxmox.Mixin.CBind'],
+
+    deleteEmpty: true,
 
     viewModel: {
 	data: {
@@ -66,7 +69,9 @@ Ext.define('PVE.form.TFASelector', {
 	    name: 'tfa',
 	    hidden: true,
 	    submitValue: true,
-	    deleteEmpty: true,
+	    cbind: {
+		deleteEmpty: '{deleteEmpty}',
+	    },
 	    bind: {
 		value: "{tfavalue}",
 	    },
-- 
2.20.1





More information about the pve-devel mailing list