[pve-devel] applied: [PATCH container] Fix move_volume by using result from parse_volume

Fabian Grünbichler f.gruenbichler at proxmox.com
Tue Apr 21 14:52:52 CEST 2020


thanks!

On April 20, 2020 1:12 pm, Fabian Ebner wrote:
> This was changed by accident by my refactoring in
> commit e4034859fd0e3491fd1aefb4f9ef44ee585aa404
> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
> 
> AFAICS the other call sites affected by the refactoring
> still use the results, but it might not hurt if somebody
> else also re-checks that commit.
> 
>  src/PVE/API2/LXC.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
> index 3a8694a..79ca025 100644
> --- a/src/PVE/API2/LXC.pm
> +++ b/src/PVE/API2/LXC.pm
> @@ -1783,7 +1783,7 @@ __PACKAGE__->register_method({
>  
>  	    die "cannot move volumes of a running container\n" if PVE::LXC::check_running($vmid);
>  
> -	    PVE::LXC::Config->parse_volume($mpkey, $conf->{$mpkey});
> +	    $mpdata = PVE::LXC::Config->parse_volume($mpkey, $conf->{$mpkey});
>  	    $old_volid = $mpdata->{volume};
>  
>  	    die "you can't move a volume with snapshots and delete the source\n"
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 




More information about the pve-devel mailing list