[pve-devel] [PATCH v3 0/3] Support all 8 corosync3 links in GUI
Stefan Reiter
s.reiter at proxmox.com
Tue Apr 21 10:54:25 CEST 2020
ping, I think we'd want this in 6.2?
On 23/03/2020 13:41, Stefan Reiter wrote:
> v2 -> v3:
> * add patch 1 (localization fix)
> * implement changes from Dominik's review:
> * use 'let' in new code
> * use references for element lookup
> * some code style nits
> * fix formatting (simpler in general with hbox, and also should work for all
> languages now)
> * fix IPv6 address selection
>
> Note: I didn't include any changes to onInputTypeChange as proposed by Dominik
> (using bindings instead of set-function calls). I couldn't quite wrap my head
> around the ExtJS side of that, so usually I'd like to talk this through in
> person, but since Dominik's on vacation and talking face-to-face right now is...
> well, not recommended in general, I left it out for now.
>
> This could easily be done in a followup though and wouldn't change the
> interface for the user, so I hope that's okay.
>
> RFC -> v2:
> * rebased on master
> * slight rewording
>
>
> manager: Stefan Reiter (3):
> gui/cluster: fix translation for cluster join button
> gui/cluster: add CorosyncLinkEdit component to support up to 8 links
> gui/cluster: add structured peerLinks to join info
>
> www/manager6/Makefile | 1 +
> www/manager6/dc/Cluster.js | 13 +-
> www/manager6/dc/ClusterEdit.js | 194 ++++++-------
> www/manager6/dc/CorosyncLinkEdit.js | 425 ++++++++++++++++++++++++++++
> 4 files changed, 534 insertions(+), 99 deletions(-)
> create mode 100644 www/manager6/dc/CorosyncLinkEdit.js
>
More information about the pve-devel
mailing list