[pve-devel] applied: [PATCH widget-toolkit] open picker for all comboboxes on focus, even if they are editable

[Thomas Lamprecht]

On 4/16/20 1:13 PM, Dominik Csapak wrote:
> when a combobox was editable, a click inside did not open the picker,
> but it would if the combobox was not editable.
> 
> Since this is
> 1. inconsistent
> 2. inconvinient (the user has to specifically press the arrow)
> 
> we already had this implemented for our ComboGrid, but not
> for regular comboboxes
> 
> This patch moves the code for this to an override for ComboBox,
> which our ComboGrid then inherits (so we do not need it there anymore)
> 
> while at it, do some non-significant code-cleanup
>  * whitespace fixes
>  * don't shadow 'me' in the focus callback
>  * fix typo in comment
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  Toolkit.js        | 31 ++++++++++++++++++++++++++++++-
>  form/ComboGrid.js | 23 -----------------------
>  2 files changed, 30 insertions(+), 24 deletions(-)
> 


applied, with typo in commit message fixed and the original original commit
mentioned, thanks!