[pve-devel] [PATCH v3 storage 2/3] Incorporate wipe_disks from PVE::Ceph::Tools

Fabian Grünbichler f.gruenbichler at proxmox.com
Thu Apr 16 10:07:00 CEST 2020


On April 16, 2020 8:57 am, Dominik Csapak wrote:
> 
>> 
>> 
>> Thanks for clearing that up, I mostly poked at it as Dominic came to me
>> asking what to do as you told him to use [0-9] and Fabian told him to go
>> back again, not knowing about your suggestion.
>> 
>> The question is, does the matching of other digit really matters at all?
>> 
>> I mean it naturally depends on what happens whit the parsed data, but most
>> of the time it should not really matter at all, or?
>> 

> bottom line: i guess both are ok when used right, but with
> [0-9] there is no ambiguity as to what it matches
> 

fine for me as well (I prefer \d for readability/shortness, but I don't 
care that strongly either way :-P).

let's put it into the style guide? 




More information about the pve-devel mailing list