[pve-devel] [PATCH v3 0/13] Fix: #2124 zstd

[Alwin Antreich]

On Thu, Apr 09, 2020 at 02:29:46PM +0200, Fabian Ebner wrote:
> Hi,
> series looks mostly good to me. Some comments on individual patches.
> Backup/restore seems to work, also still with the other compression formats.
> The tests for path_to_volume_id actually uncover a bug and a missing feature
> in the implementation in Storage.pm, which should be fixed.
I'll look into it.

> 
> For the patches that won't change (much):
> Reviewed-By: Fabian Ebner <f.ebner at proxmox.com>
> Tested-By: Fabian Ebner <f.ebner at proxmox.com>
Thanks for review and testing.

> 
> For a potential follow-up, I feel like the parsing of the backup filename
> might need its own method, rather than have all those pattern matchings in
> different places.
That was my intent with archive_info, it could be extend later on. :)