[pve-devel] [PATCH v9 0/6] Add basics for custom CPU models

[Thomas Lamprecht]

On 4/6/20 3:01 PM, Stefan Reiter wrote:
> On 06/04/2020 14:42, Fabian Ebner wrote:
>> Hi,
>>
>> reviewed this series today. It's my first time looking at all the CPU related code, so I'm not sure I understood all the details.
>>
>> The patches work as described (patch #2 even does more ;) and I do have 2 minor comments/suggestions on the individual patches. And needs to be rebased on current master again. With that:
>>
>> Reviewed-By: Fabian Ebner <f.ebner at proxmox.com>
>> Tested-By: Fabian Ebner <f.ebner at proxmox.com>
>>
> 
> Thanks for the review! I'll rebase it (I assume the main thing will be the recent vm_start refactoring) and send a v10.

May want to coordinate with Fabian G.

> 
> @Thomas: In cases like this, should I add the R-by/T-by tags to the v10 commits myself (for those I don't majorly change anyhow) or will you still do that when applying?
>
Yes, it would be great if you pick them up - at least for those patches
which did not get changed for the next submission, changes resulting from
the rebase are naturally fine :)