[pve-devel] applied-series: [PATCH manager 1/2] ui: ceph/ServiceList: stop leaky versionsstores

[Thomas Lamprecht]

On 4/2/20 10:53 AM, Dominik Csapak wrote:
> on the view destroy we have to stop the updatestore again,
> they do not get cleaned up by a destroy because until they are stopped
> the have a reference on themselves, which prevent a garbage collection
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  www/manager6/ceph/ServiceList.js | 1 +
>  1 file changed, 1 insertion(+)
> 

applied both patches with a followup, as 2/2 missed another autoLoad:



commit e475a7788c9cc6f194f8f6bdc6bc55e6e566bf30 (HEAD -> master, proxdev/master)
Author: Thomas Lamprecht <t.lamprecht at proxmox.com>
Date:   Thu Apr 2 12:48:02 2020 +0200

    ui: ceph/ServiceList: do not autoLoad the rstore
    
    The 'autoStart' triggers a initial load already
    
    Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>

diff --git a/www/manager6/ceph/ServiceList.js b/www/manager6/ceph/ServiceList.js
index ce688eae..581bd554 100644
--- a/www/manager6/ceph/ServiceList.js
+++ b/www/manager6/ceph/ServiceList.js
@@ -134,7 +134,6 @@ Ext.define('PVE.node.CephServiceList', {
            view.on('destroy', view.versionsstore.stopUpdate);
 
            view.rstore = Ext.create('Proxmox.data.UpdateStore', {
-               autoLoad: true,
                autoStart: true,
                interval: 3000,
                storeid: 'ceph-' + view.type + '-list' + view.nodename,