[pve-devel] [PATCH manager 1/2] ui: ceph/ServiceList: stop leaky versionsstores

Dominik Csapak d.csapak at proxmox.com
Thu Apr 2 10:53:44 CEST 2020


on the view destroy we have to stop the updatestore again,
they do not get cleaned up by a destroy because until they are stopped
the have a reference on themselves, which prevent a garbage collection

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 www/manager6/ceph/ServiceList.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/ceph/ServiceList.js b/www/manager6/ceph/ServiceList.js
index b7670395..d5c317c1 100644
--- a/www/manager6/ceph/ServiceList.js
+++ b/www/manager6/ceph/ServiceList.js
@@ -132,6 +132,7 @@ Ext.define('PVE.node.CephServiceList', {
 	    });
 
 	    view.versionsstore.on('load', this.getMaxVersions, this);
+	    view.on('destroy', view.versionsstore.stopUpdate);
 
 	    view.rstore = Ext.create('Proxmox.data.UpdateStore', {
 		autoLoad: true,
-- 
2.20.1





More information about the pve-devel mailing list