[pve-devel] [PATCH proxmox-widget-toolkit] form: add Proxmox.form.field.DisplayEdit

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Apr 2 10:23:36 CEST 2020


On 4/2/20 10:15 AM, Dominik Csapak wrote:
> i forgot the nit inline, now really ^^
> 
> [snip]
>>>
>>>   Makefile            |  1 +
>>>   form/DisplayEdit.js | 71 +++++++++++++++++++++++++++++++++++++++++++++
>>>   2 files changed, 72 insertions(+)
>>>   create mode 100644 form/DisplayEdit.js
>>>
>>> diff --git a/Makefile b/Makefile
>>> index 703b570..a729b95 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -15,6 +15,7 @@ JSSRC=                    \
>>>       data/ObjectStore.js        \
>>>       data/RRDStore.js        \
>>>       data/TimezoneStore.js        \
>>> +    form/DisplayEdit.js        \
>>>       form/ExpireDate.js        \
>>>       form/IntegerField.js        \
>>>       form/TextField.js        \
>>> diff --git a/form/DisplayEdit.js b/form/DisplayEdit.js
>>> new file mode 100644
>>> index 0000000..9b3f1c0
>>> --- /dev/null
>>> +++ b/form/DisplayEdit.js
>>> @@ -0,0 +1,71 @@
>>> +Ext.define('Proxmox.form.field.DisplayEdit', {
>>> +    extend: 'Ext.form.FieldContainer',
>>> +    alias: ['widget.pmxDisplayEditField'],
> 
> i would like to use
> xtype: 'pmxDisplayEditField',
> here
> 

Any reason for that? It evaluates to the same after all.. xtype is just an
alias with prefixed "widget."





More information about the pve-devel mailing list