[pve-devel] applied-series: [PATCH V2 storage 0/3] Fix 2384, several pools from same server

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Sep 26 19:02:54 CEST 2019


On 9/26/19 6:52 PM, Daniel Berteaud wrote:
> ----- Le 26 Sep 19, à 18:46, Thomas Lamprecht t.lamprecht at proxmox.com a écrit :
> 
>>>
>>> Changes since V1
>>>   * Avoid nested hash accesses
>>>   * Re-use variables
>>>
>>> Daniel Berteaud (3):
>>>   LIO: Make the target cache works per target and portal
>>>   LIO: Prefix backstores with the pool name
>>>   LIO: re-use variables
>>>
>>>  PVE/Storage/LunCmd/LIO.pm | 61 +++++++++++++++++++++++++++++++--------
>>>  1 file changed, 49 insertions(+), 12 deletions(-)
>>>
>>
>> applied all three patches, much thanks!
> 
> 
> Thanks to you for reviewing / merging.
> Should I close bug #2384 now ? (not sure if you have some particular workflow on BZ)

Hmm, as you're here not only the Reporter but effectively also the
Assignee which patched the issue yourself you have the full rights
to close it.
But, we normally wait until the fix(es) get packaged, else people will
still complain as they do not have it yet available (easily).
Sometimes, if I'm really sure it is fixed, I just close it nonetheless
and write something akin to:

"Fixed by [reference to commit] in [package] not yet released, should get
available in [current-version + 1]"

so that I do not forget to close it. For your own bugs you can do as it
seems practical to you in such a case. :)

cheers,
Thomas






More information about the pve-devel mailing list