[pve-devel] [PATCH common/qemu-server/container] fix #1934: add tags to guests

Dominik Csapak d.csapak at proxmox.com
Tue Sep 24 08:17:30 CEST 2019


On 9/23/19 5:34 PM, Thomas Lamprecht wrote:
> On 9/10/19 2:57 PM, Dominik Csapak wrote:
>> this series lets users add tags to guest configs
>> these do not have any concrete meaning but are intended to be used
>> by management software such as config management systems
>>
> 
> Looks OK, besides some comments in the common patch.
> I'd like to have basic Web interface display/edit and being able to search
> after them from day 1.

ok, no problem, will send a v2 with gui parts included,
will take a few days though i guess..

> 
>> in the future we could:
>> * show them in the gui
>> * add a seperate api call to get/set/remove tags individually
>> * filter the gui by tag
>> * add them to storages/realms/...
>>
>> depending on what users need and is reasonable to implement
>>
>> this series is partly a replacement for my older patchseries,
>> which used the tags for qemus fw_cfg (this will be its own config)
>>
>> pve-common:
>>
>> Dominik Csapak (1):
>>    JSONSchema: add pve-tag format
>>
>>   src/PVE/JSONSchema.pm | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> qemu-server:
>>
>> Dominik Csapak (1):
>>    add 'tags' option
>>
>>   PVE/API2/Qemu.pm  | 1 +
>>   PVE/QemuServer.pm | 6 ++++++
>>   2 files changed, 7 insertions(+)
>>
>> pve-container:
>>
>> Dominik Csapak (1):
>>    add 'tags' option
>>
>>   src/PVE/LXC/Config.pm | 9 +++++++--
>>   1 file changed, 7 insertions(+), 2 deletions(-)
>>





More information about the pve-devel mailing list