[pve-devel] [PATCH manager v2 4/4] spice: Add enhancements to VM Creation wizard

Aaron Lauterer a.lauterer at proxmox.com
Tue Sep 17 11:35:51 CEST 2019


For a cleaner UI the SCSI Controller (pveScsiHwSelector) is moved to the
left column below the VGA selector. The new Spice enhancements
components is placed in the right column and enabled if qxl/spice is
selected in the VGA selector.

Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
---
 www/manager6/qemu/SystemEdit.js | 34 ++++++++++++++++++++++++---------
 1 file changed, 25 insertions(+), 9 deletions(-)

diff --git a/www/manager6/qemu/SystemEdit.js b/www/manager6/qemu/SystemEdit.js
index 846baa73..dac0cc04 100644
--- a/www/manager6/qemu/SystemEdit.js
+++ b/www/manager6/qemu/SystemEdit.js
@@ -79,7 +79,26 @@ Ext.define('PVE.qemu.SystemInputPanel', {
 	    deleteEmpty: false,
 	    fieldLabel: gettext('Graphic card'),
 	    name: 'vga',
-	    comboItems: PVE.Utils.kvm_vga_driver_array()
+	    comboItems: PVE.Utils.kvm_vga_driver_array(),
+	    listeners: {
+		change: function(f, value, old) {
+		    var sef = this.up('pveQemuSystemPanel').down('pveSpiceEnhancementSelector');
+		    if (/^(qxl)(\d?)$/.test(value)) {
+			sef.setDisabled(false);
+		    } else {
+			sef.setDisabled(true);
+		    }
+		}
+	    }
+	},
+	{
+	    xtype: 'pveScsiHwSelector',
+	    name: 'scsihw',
+	    value: '__default__',
+	    bind: {
+		value: '{current.scsihw}'
+	    },
+	    fieldLabel: gettext('SCSI Controller')
 	},
 	{
 	    xtype: 'proxmoxcheckbox',
@@ -88,18 +107,15 @@ Ext.define('PVE.qemu.SystemInputPanel', {
 	    defaultValue: 0,
 	    deleteDefaultValue: true,
 	    fieldLabel: gettext('Qemu Agent')
-	}
+	},
     ],
 
     column2: [
 	{
-	    xtype: 'pveScsiHwSelector',
-	    name: 'scsihw',
-	    value: '__default__',
-	    bind: {
-		value: '{current.scsihw}'
-	    },
-	    fieldLabel: gettext('SCSI Controller')
+	    xtype: 'pveSpiceEnhancementSelector',
+	    name: 'spice_enhancements',
+	    insideWizard: true,
+	    disabled: true,
 	}
     ],
 
-- 
2.20.1





More information about the pve-devel mailing list