[pve-devel] [PATCH] Check if VM is running when migrating with --online 1

[Stefan Reiter]

On 9/16/19 9:46 AM, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
>   PVE/API2/Qemu.pm | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index b30931d..ab5912c 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -3341,6 +3341,9 @@ __PACKAGE__->register_method({
>   	if (PVE::QemuServer::check_running($vmid)) {
>   	    die "cant migrate running VM without --online\n"
>   		if !$param->{online};
> +	} else {
> +	    die "cant migrate stopped VM with --online\n"
> +		if $param->{online};

Do we actually want to forbid this, or maybe just ignore (potentially 
with a warning)?

I'm imagining a use-case where someone runs a migration from a script, 
they'd now have to check if the VM is running to find the correct "qm 
migrate" command. Maybe something like "--online auto"?

>   	}
>   
>   	my $storecfg = PVE::Storage::config();
>