[pve-devel] [PATCH v3 qemu-server] add check to resize disk if current size could not be determined

Tim Marx t.marx at proxmox.com
Thu Sep 12 12:56:18 CEST 2019


This check ensures that disks aren't unintentionally shrunken, if the
size is zero due to an underlying problem.
---
 PVE/API2/Qemu.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 3355c8b..e09a0f7 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -3573,6 +3573,8 @@ __PACKAGE__->register_method({
 	    PVE::Storage::activate_volumes($storecfg, [$volid]);
 	    my $size = PVE::Storage::volume_size_info($storecfg, $volid, 5);
 
+	    die "Size of volume $volid couldn't be determined\n" if (!defined($size));
+
 	    die "internal error" if $sizestr !~ m/^(\+)?(\d+(\.\d+)?)([KMGT])?$/;
 	    my ($ext, $newsize, $unit) = ($1, $2, $4);
 	    if ($unit) {
-- 
2.20.1




More information about the pve-devel mailing list