[pve-devel] applied-series: [PATCH qemu-server v4 0/4] add reboot api

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Sep 11 14:53:25 CEST 2019


On 11.09.19 14:07, Dominik Csapak wrote:
> this adds a reboot api call for vms, which uses a reboot request file
> that gets detected by the qm cleanup call to start the vm again
> 
> this api call is useful when users want to apply pending hardware changes
> without waiting for the vm to shutdown

applied series, thanks!

WebUI and a widget-tk "task_desc_table" entry would be nice now :)
> 
> changes from v3:
> * rebased on master
> * used ENOENT check to avoid race
> * improved comment
> * improved eval/error handling
> * split refactoring out to its own commit
> * move storecfg into vm_reboot
> 
> changes from v2:
> * reordered patches (index links are now 1/4)
> * refactored vm_stop and introduced vm_reboot for better function signatures
> * renamed to clear/create_reboot_request
> * improved clearing error handling
> 
> changes from rfc:
> * move the creation/deletion into their own subs
> * only create reboot trigger while having the lock during shutdown
> * cleanup the trigger on vm startup
> * use always vm_stop even for ha vms, since we do not want to change
>   the target state
> 
> Dominik Csapak (4):
>   add create and remove reboot trigger subs
>   qm: cleanup: detect and handle reboot trigger
>   refactor vm_stop locked code
>   api: add reboot api call
> 
>  PVE/API2/Qemu.pm  |  59 +++++++++++++++
>  PVE/CLI/qm.pm     |  14 ++++
>  PVE/QemuServer.pm | 187 ++++++++++++++++++++++++++++------------------
>  3 files changed, 189 insertions(+), 71 deletions(-)
> 





More information about the pve-devel mailing list