[pve-devel] applied: [PATCH storage] fix vmid filter for backup listing

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Sep 9 16:40:00 CEST 2019


On 06.09.19 14:12, Dominik Csapak wrote:
> $1 and $2 get set to undef from the vmid filter regex, so we have to do
> the name/format regex after, else we get errors like:
> 
> 'use of unitiialized value $1[...]'
> 
> and the listing is empty
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  PVE/Storage/Plugin.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm
> index 9a419f1..2a4e88b 100644
> --- a/PVE/Storage/Plugin.pm
> +++ b/PVE/Storage/Plugin.pm
> @@ -925,8 +925,8 @@ my $get_subdir_files = sub {
>  	    $info = { volid => "$sid:vztmpl/$1", format => "t$2" };
>  
>  	} elsif ($tt eq 'backup') {
> -	    next if $fn !~ m!/([^/]+\.(tar|tar\.gz|tar\.lzo|tgz|vma|vma\.gz|vma\.lzo))$!;
>  	    next if defined($vmid) && $fn !~  m/\S+-$vmid-\S+/;
> +	    next if $fn !~ m!/([^/]+\.(tar|tar\.gz|tar\.lzo|tgz|vma|vma\.gz|vma\.lzo))$!;
>  
>  	    $info = { volid => "$sid:backup/$1", format => $2 };
>  
> 

applied, thanks!




More information about the pve-devel mailing list