[pve-devel] applied-series: [PATCH storage 2/2] warn if filesize info couldn't be read due to error
Thomas Lamprecht
t.lamprecht at proxmox.com
Mon Sep 9 15:41:37 CEST 2019
On 09.09.19 12:56, Tim Marx wrote:
> This sh
abrupt CI message ending?
> Signed-off-by: Tim Marx <t.marx at proxmox.com>
> ---
> PVE/Storage/Plugin.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm
> index ed71fe4..6b79e7a 100644
> --- a/PVE/Storage/Plugin.pm
> +++ b/PVE/Storage/Plugin.pm
> @@ -742,6 +742,8 @@ sub file_size_info {
> });
> };
>
> + warn $@ if $@;
> +
applied both, even though `qemu-img info FN` still exits with 0 if FN does
not exists, so at least "common" possible problematic situations won't be
caught by this, I'd guess?
> return wantarray ? ($size, $format, $used, $parent) : $size;
> }
>
> --
> 2.20.1
>
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
More information about the pve-devel
mailing list