[pve-devel] [PATCH v2 qemu-server 1/1] Add support for up to 16 PCI(e) devices

[Aaron Lauterer]

On 9/6/19 2:45 PM, Dominik Csapak wrote:
> looks mostly ok, one (important) comment inline
> 
>>       # win7 is picky about pcie assignments
>>       hostpci0bus0 => { bus => "pcie.0", addr => 16 },
>>       hostpci1bus0 => { bus => "pcie.0", addr => 17 },
>>       hostpci2bus0 => { bus => "pcie.0", addr => 18 },
>>       hostpci3bus0 => { bus => "pcie.0", addr => 19 },
>>       ivshmem => { bus => 'pcie.0', addr => 20 },
>> +    hostpci4bus0 => { bus => "pcie.0", addr => 9 },
>> +    hostpci5bus0 => { bus => "pcie.0", addr => 10 },
>> +    hostpci6bus0 => { bus => "pcie.0", addr => 11 },
>> +    hostpci7bus0 => { bus => "pcie.0", addr => 12 },
>> +    hostpci8bus0 => { bus => "pcie.0", addr => 13 },
>> +    hostpci9bus0 => { bus => "pcie.0", addr => 14 },
>> +    hostpci10bus0 => { bus => "pcie.0", addr => 15 },
>> +    hostpci11bus0 => { bus => "pcie.0", addr => 20 },
> 
> addr 20 is already used by ivshmem
> 
> i would prefer to have the list in order of the addresses, so that this
> will be more obvious and does not happen. also thomas mentioned offlist 
> that it would be nice to have a test that automatically checks this, and 
> i agree, but no one had time to do this (for now)
> 

Thanks for catching that one!