[pve-devel] [PATCH 0/2] code refactoring for lxc pending changes feature

[Thomas Lamprecht]

On 04.09.19 18:00, Oguz Bektas wrote:
> this patch series moves some pending changes related functions into
> AbstractConfig. the only thing that changes is that these are now class methods,
> since they need to be inherited in LXC::Config and QemuConfig.
> (the functionality in Qemu side should stay the same)
> 
> for now, vmconfig_apply_pending and vmconfig_hotplug_pending are left to be
> implemented in the respective Config classes, since there are different
> special cases between Qemu and LXC to be handled.
> 
> 
> 

I want to see the LXC code too, to ensure the method split and use
is a good fit to share the implementation between both as much as
possible, please send that too..

> 
> 
> pve-guest-common:
> 
> Oguz Bektas (1):
>   move pending changes related functions into AbstractConfig
> 
>  PVE/AbstractConfig.pm | 79 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 79 insertions(+)
> 
> 
> qemu-server:
> 
> Oguz Bektas (1):
>   move pending changes related functions from QemuServer to QemuConfig
> 
>  PVE/API2/Qemu.pm             |  20 +--
>  PVE/QemuConfig.pm            | 233 ++++++++++++++++++++++++++
>  PVE/QemuServer.pm            | 306 +----------------------------------
>  PVE/QemuServer/ImportDisk.pm |   4 +-
>  4 files changed, 250 insertions(+), 313 deletions(-)
>