[pve-devel] applied: [RFC PATCH common] cli: prettify tables even more

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Sep 5 07:08:46 CEST 2019


On 04.09.19 19:36, Dietmar Maurer wrote:
> What about my doubts? AFAIK nobody answered my mail? (or maybe i missed a mail)
> 

Wolfgang did answer:

> On Wed, Aug 21, 2019 at 09:35:56PM +0200, Dietmar Maurer wrote:
>> Are your sure common terminals support those characters?
>>
>> They did not when I tested ...
> 
> Curious, when using utf-8 encoding for those characters I wouldn't see
> how these characters would be any more special than any other?
> In any case, tested urxvt, terminator, xfce4-terminal, gnome-terminal,
> lxterminal.
> Also note that all those symbols already existed in the extended ascii set,
> codes 181, 198 and 216, and yes, those do show up correctly in dosbox 


And thus I saw no issue left..



>> On 4 September 2019 16:06 Thomas Lamprecht <t.lamprecht at proxmox.com> wrote:
>>
>>  
>> On 21.08.19 14:33, Wolfgang Bumiller wrote:
>>> Separate the header with a double line.
>>>
>>> Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
>>> ---
>>>  src/PVE/CLIFormatter.pm | 18 +++++++++++++++++-
>>>  1 file changed, 17 insertions(+), 1 deletion(-)
>>>
>>
>> applied, thanks!




More information about the pve-devel mailing list