[pve-devel] [PATCH manager v2 4/5] gui: add tag edit windows for guests

[Dominik Csapak]

On 10/30/19 9:30 AM, Thomas Lamprecht wrote:
> On 10/30/19 9:23 AM, Dominik Csapak wrote:
>> On 10/30/19 8:51 AM, Thomas Lamprecht wrote:
>>> On 10/3/19 1:50 PM, Dominik Csapak wrote:
>>>> so that the user can edit the tags in the gui
>>>
>>> IMO the options is not really "correct", it's not a guest option
>>> at all. Rather this fits to the "Notes" field of the Summary panel,
>>> maybe finding there a place would be better..
>>
>> i see what you mean, but i could not figure out where else to put it...
>> options also include meta settings like 'bootorder','name' or 'protected' which do not really influence the guest either (the name only with cloudinit)
> 
> That's not true, the all influence the guest!
> name -> CT hostname
> bootorder -> actively influences when a CT is started
>    (or if at all autostarted)
> protected -> actively prevents CT destruction
> 
> But tags is, as your other patch says, really just meta-information
> just like the description/notes, so IMO this is really different than
> the other things currently in options.
> 

ok, yeah i see what you mean now,
i thought you meant influence the guest as in 'inside'

but yeah you're right