[pve-devel] applied: [PATCH manager] aplinfo: see trusted keys as build product, always assembly

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Oct 30 08:57:47 CET 2019


On 10/16/19 11:05 AM, Thomas Lamprecht wrote:
> Don't track the binary trustedkeys.gpg but see it just as normal
> build product with the armored keys as source.
> 
> This ensures we always ship those from TRUSTED_KEYS variable, not
> more, not less.
> 
> Instead of the "gpg import+export in temporary home dir" just
> de-armor and concatenate them our self, that's what happens anyway.
> 
> This could be even simplified by just using base64 -d on the pubkeys,
> after the non base64 stuff was trimmed, that would omit our need for
> gpg here completely.
> 
> Thanks to Wolfgang B. for giving the idea to just do simple stuff :)
> 
> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> ---
>  aplinfo/Makefile        |  26 ++++++--------------------
>  aplinfo/trustedkeys.gpg | Bin 3602 -> 0 bytes
>  2 files changed, 6 insertions(+), 20 deletions(-)
>  delete mode 100644 aplinfo/trustedkeys.gpg
> 

due to no objections, and the reason that forgetting this could have
not-so-ideal effects, applied. Just sent a patch if you think that something
is still off ;-)




More information about the pve-devel mailing list