[pve-devel] applied: [PATCH v2 common 01/11] Make get_host_arch return raw uname entry

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Oct 29 07:12:12 CET 2019


On 10/28/19 12:59 PM, Stefan Reiter wrote:
> The current version had only one user in LXC, so move the LXC-specific
> code there to reuse this in QemuServer.
> 
> Also cache, since the host's architecture can't change during runtime.
> 
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> ---
>  src/PVE/Tools.pm | 17 +++++------------
>  1 file changed, 5 insertions(+), 12 deletions(-)
> 


applied, but dropped the prototype for now, even if /could/ makes sense
(or at least not hurt) it feels like added by mistake, and as you commit
message nowhere points out why this was done in this patch I want to rather
be on the safe side (and need to bump common ;))




More information about the pve-devel mailing list