[pve-devel] [PATCH container] add 'lock' as a fastplug option

Oguz Bektas o.bektas at proxmox.com
Thu Oct 24 17:19:11 CEST 2019


On Thu, Oct 24, 2019 at 05:12:20PM +0200, Thomas Lamprecht wrote:
> On 10/24/19 3:58 PM, Oguz Bektas wrote:
> > lock option needs to be fastpluggable when modifying with 'pct set'.
> > otherwise it registers as a pending change.
> > 
> possible stupid question ahead: do I want to be able to set/clear a
> lock at all with pct set??
why not? might be useful for testing purposes, and it doesn't hurt to
allow it i think.
> 
> Same for qm, I'd guess. But it works there, soo..? IMO a bit strange,
> to say the least ^^
qm already had 'lock' in the fastplug options (that's why it works there), i
forgot to add it in my pending changes series.
> 
> > Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
> > ---
> >  src/PVE/LXC/Config.pm | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
> > index b744d4f..d624b0b 100644
> > --- a/src/PVE/LXC/Config.pm
> > +++ b/src/PVE/LXC/Config.pm
> > @@ -1106,6 +1106,7 @@ my $LXC_FASTPLUG_OPTIONS= {
> >      'hookscript' => 1,
> >      'cores' => 1,
> >      'tags' => 1,
> > +    'lock' => 1,
> >  };
> >  
> >  sub vmconfig_hotplug_pending {
> > 




More information about the pve-devel mailing list