[pve-devel] [PATCH installer/manager v2] generate /etc/aliases.db

[Stoiko Ivanov]

The changeset fixes two issues with our ISO-installer:
* it ensures that 'newaliases is run upon new installations and once on upgrade
  of pve-manger to a version > 6.0-10
* the written /etc/postfix/main.cf now contains 'compatibility_level=2'

One side-effect I'm not too sure about is, that if we generate '/etc/aliases.db'
on a long-running system which was lacking it, all mails which are queued on
the system due to the missing aliases.db will get sent in one go.
This could be potentially an unpleasant surprise in certain setups.
(No idea how to prevent that, apart from simply dropping the patch and
only announcing the issue on our channels...)

The postinst-invocation was added to pve-manager instead of pve-common, after
a short talk with Thomas off-list (it's not needed for PMG, and we will check
the pve-manager postinst script when time for PVE 7.X comes)

I did some more testing:
* reloading postfix is not necessary - it picks up the changes once the 'local'
  process is restarted (although the statement in the manpage of it 'taking
  about a minute' resulted in 30' on my tests (probably due to the difference
  of updating the file vs. creating it anew)
* users installing on top of Debian are most likely not affected:
  * either they just install proxmox-ve (then exim is chosen as MTA, which
  uses '/etc/aliases' directly (and does not send e-mail if you do not configure
  it explicitly)
  * users installing with the instructions in our wiki-page (i.e. installing
  postfix and proxmox-ve) get asked about the mail-configuration and the
  postfix maintainer-scripts take care of running newaliases

changes v1->v2:
* split installer changes into two separate patches
* added patch to pve-manager's postinst script calling newaliases
  (to fix the issue for users having installed from our ISO before)

Thanks to Martin for reporting this!


pve-installer:
Stoiko Ivanov (2):
  raise postifx main.cf compatibility_level to 2
  ensure /etc/aliases.db is generated

 proxinstall | 4 ++++
 1 file changed, 4 insertions(+)

pve-manager:
Stoiko Ivanov (1):
  add versioned postinst run of newaliases

 debian/postinst | 7 +++++++
 1 file changed, 7 insertions(+)

-- 
2.20.1