[pve-devel] [PATCH installer] fix postfix installation

[Thomas Lamprecht]

On 10/21/19 10:11 PM, Stoiko Ivanov wrote:
> by:
> * running /usr/bin/newaliases (generating /etc/aliases.db)
> * setting the compatibility_level to 2
> ** otherwise a warning was issued with broken aliases.db that the system
>    is using the backward compatible setting of $mydestination for $relay_domain
>    (see [0]).
> 

as said in the past, if you start making bulletin points chances are
high that it should be done in two different patches.

One patch: "raise postifx main.cf compatibility_level to 2"
Another patch: "ensure /etc/aliases.db is generated"

But for the latter one we had a fix which sounds like a possible cause of
this[0], it was fixed in the ISO build environment and in a postinst hook
for pve-common[1]. AFAICT, the postinst hook misses a newaliases
regeneration, but otherwise this should be already fixed?

Else, a possible better option would be to add this into the postinst,
one for the upgrade from broken to corrrect (with the current version),
and one for new installations - which could also ensure that PVE on Debian
installations get this right.

For PMG it's not too relevant, as the clamav postinst triggers a newaliases
anyway, if the "clamav: root" entry had to be added (which is always the case,
besides the situations where one had already a Debian with ClamAV setup
before installing PMG).. 

[0]: https://pve.proxmox.com/pipermail/pve-user/2019-September/170995.html
[1]: https://git.proxmox.com/?p=pve-common.git;a=commitdiff;h=c5c5812e2325d90c832207862f2340cb7303667b

> Tested by installing from ISO and creating a cronjob which runs 'echo test'
> every minute.
> 
> Thanks to Martin for reporting this!
> 
> [0] http://www.postfix.org/COMPATIBILITY_README.html#relay_domains
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
> ---
>  proxinstall | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/proxinstall b/proxinstall
> index d9e2211..5d02b34 100755
> --- a/proxinstall
> +++ b/proxinstall
> @@ -328,6 +328,8 @@ mynetworks = 127.0.0.0/8
>  inet_interfaces = loopback-only
>  recipient_delimiter = +
>  
> +compatibility_level = 2
> +
>  _EOD
>  
>  sub shellquote {
> @@ -1641,6 +1643,8 @@ _EOD
>  	syscmd("chroot $targetdir /usr/sbin/postfix check");
>  	# cleanup mail queue
>  	syscmd("chroot $targetdir /usr/sbin/postsuper -d ALL");
> +	# create /etc/aliases.db (/etc/aliases is shipped in the base squashfs)
> +	syscmd("chroot $targetdir /usr/bin/newaliases");
>  
>  	# enable NTP (timedatectl set-ntp true  does not work without DBUS)
>  	syscmd("chroot $targetdir /bin/systemctl enable systemd-timesyncd.service");
>