[pve-devel] [manager 1/6] Add plugin property for choosing different ACME modes.

[Fabian Grünbichler]

On October 14, 2019 1:08 pm, Wolfgang Link wrote:
> With this property, different methods for ACME challenges are possible.
> 
> At the moment we will only support HTTP-01 through StandAlone
> and DNS-01 through ACME_sh Plugin.
> ---
>  PVE/NodeConfig.pm | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/PVE/NodeConfig.pm b/PVE/NodeConfig.pm
> index b52868e2..a807c710 100644
> --- a/PVE/NodeConfig.pm
> +++ b/PVE/NodeConfig.pm
> @@ -71,6 +71,13 @@ my $confdesc = {
>  
>  my $acmedesc = {
>      account => get_standard_option('pve-acme-account-name'),
> +    plugin => {
> +	type => 'string',
> +	enum => ['standalone'],
> +	default => 'standalone',
> +	optional => 1,
> +	description => 'Supported ACME Plugins',

ACME plugin to use

?

we probably do need an API call to discover plugins (or plugin 
instances) though (for the GUI), so this should then be refactored 
that the enum is generated here as well, or it would no longer be an 
enum but just an ID value..

also, acme.sh ties the specific validation method to the domain - should 
we do the same (see also comment on the 'alias' property)

> +    },
>      domains => {
>  	type => 'string',
>  	format => 'pve-acme-domain-list',
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
>