[pve-devel] applied: [PATCH v4 pve-docs 1/1] gen vzdump: json_config_properties() moved from VZDump to VZDump::Common

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Oct 18 11:00:50 CEST 2019


On 10/15/19 1:00 PM, Christian Ebner wrote:
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
> version 4:
>     * not present in v3
> 
>  gen-vzdump.conf.5-opts.pl | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gen-vzdump.conf.5-opts.pl b/gen-vzdump.conf.5-opts.pl
> index 4e013fb..dc1e0c5 100755
> --- a/gen-vzdump.conf.5-opts.pl
> +++ b/gen-vzdump.conf.5-opts.pl
> @@ -4,9 +4,9 @@ use lib '.';
>  use strict;
>  use warnings;
>  use PVE::RESTHandler;
> -use PVE::VZDump;
> +use PVE::VZDump::Common;
>  
> -my $prop = PVE::VZDump::json_config_properties();
> +my $prop = PVE::VZDump::Common::json_config_properties();
>  my $skip = {
>      all => 1,
>      exclude => 1,
> 

applied, but IMO this thing should be really where gen-vzdump.conf.5
is shipped, makes no sense to have here, just PITA headache, anyway
nothing directly related to your patch, so thanks!




More information about the pve-devel mailing list