[pve-devel] [PATCH v4 0/7] add purge option for VM/CT destroy

[Fabian Grünbichler]

On October 17, 2019 6:40 pm, Thomas Lamprecht wrote:
> On 10/15/19 1:00 PM, Christian Ebner wrote:
>> When destroying a VM/CT, we intentionally did not remove all related configs such
>> as backup or replication jobs.
>> The intention of this flag is to allow the removal of such configs on destroy.
>> 
>> This patch series implements this functionality and additionally moves the
>> cfs register code for vzdump.cron to pve-guest-common to avoid a cyclic
>> dependency.
> 
> Looks OK for me, after a quick look.
> 
> If there are no high-level objections to the move of VZDump config/schema
> stuff I'd give it a deeper look + test and apply it, if all seems well.
> 
> Fabian, Dietmar?

no objections from me (see discussion of previous version ;))

from a quick glance: the commit IDs in commit messages are probably not 
a good idea, and this conflicts with the "fix locking in vm_destroy API 
path" patch by Dominic[1] so it might need a rebase.

[1]: applied for qemu-server, still missing for pve-container - 
potentially the latter could be fixed together with this series?