[pve-devel] [PATCH v3 00/19] lxc pending changes

[Thomas Lamprecht]

On 10/14/19 10:28 AM, Oguz Bektas wrote:
> this patch series makes it possible to add/delete/revert pending changes
> in the backend for containers.
> 
> v2 -> v3:
> * reorder and squash/split commits
> * split load_current_config and load_snapshot_config
> * use perl hash representation for the pending delete hash
> * remove semi-related stuff (i.e. namespacing snapshots, which i'll send
> in another patch)
> * add conf_table_with_pending guesthelper for the vm_pending API call
> * move back $param checks to lxc API call instead of update_pct_config
> * error handling for vmconfig_apply_pending
> 

from a quick glance: order is much better now, found nothing completely
off..

> 
> pve-guest-common:
> 
> Oguz Bektas (4):
>   abstractconfig: add pending changes related helpers
>   abstractconfig: add load_current_config and load_snapshot_config
>   helpers: add pending-aware guest config printer from qemu-server
>   helpers: add method to represent config as a table
> 
>  PVE/AbstractConfig.pm | 109 ++++++++++++++++++++++++++++++++++++++++++
>  PVE/GuestHelpers.pm   |  61 +++++++++++++++++++++++
>  2 files changed, 170 insertions(+)
> 
> qemu-server:
> 
> Oguz Bektas (4):
>   api: use shared methods in config GET
>   use new config helpers from guest-common for pending changes
>   cli: use guesthelper for pending
>   api: use guesthelper method for vm_pending path
> 
>  PVE/API2/Qemu.pm  | 99 ++++++++++-------------------------------------
>  PVE/CLI/qm.pm     | 28 +-------------
>  PVE/QemuServer.pm | 79 ++++---------------------------------
>  3 files changed, 30 insertions(+), 176 deletions(-)
> 
> 
> pve-container:
> 
> Oguz Bektas (11):
>   adapt CT config parser for pending changes
>   add lxc/pending API path
>   add 'pct pending'
>   api: config: use shared guesthelpers in GET call
>   skip pending changes while cloning
>   skip pending changes while taking backup
>   prepend underscores for is_volume_in_use helper
>   allow to check for in-use volumes in pending section
>   add vmconfig_hotplug_pending and vmconfig_apply_pending
>   apply pending changes during container start
>   implement pending changes
> 
>  src/PVE/API2/LXC.pm        |  57 ++++
>  src/PVE/API2/LXC/Config.pm |  55 ++--
>  src/PVE/CLI/pct.pm         |   3 +
>  src/PVE/LXC.pm             |  21 +-
>  src/PVE/LXC/Config.pm      | 521 ++++++++++++++++++++-----------------
>  src/PVE/VZDump/LXC.pm      |   1 +
>  6 files changed, 395 insertions(+), 263 deletions(-)
> 
>